Repository navigation
feat: add team setting to change default filters behavior - #3747
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6fe1e55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Additional context: grazes a critical path (1 lines in Review process: Full human review — logic, architecture, edge cases. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
3 finding(s): 🔴 0 P0/P1 · 🟡 1 P2 · 🔵 2 P3 1 posted as inline comment(s) on the changed lines. 2 P3 folded at the bottom. 🔵 2 P3 — no action needed before merge
Priority comes from a separate grading pass over the finished review. P3 is folded here instead of posted inline. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. The feature is wired correctly end-to-end: the new 🟡 P2 -- recommended
🔵 P3 nitpicks (4)
Reviewers (8): correctness, testing, maintainability, project-standards, api-contract, kieran-typescript, agent-native, previous-comments. Testing gaps: No unit test covers the show-all-values precedence/reset logic; no integration test round-trips Notes: The changeset lists 3 packages; the changeset-bot's "4 packages" count reflects dependency fan-out to No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 473 passed • 1 skipped • 1144s
Tests ran across 4 shards in parallel. |
Summary
Team setting can toggle exact or all mode for all users default value
Screenshots or video
export-1795205098275.mp4
References